starrocks
starrocks copied to clipboard
[Enhancement] Optimize broker load small orc files
Why I'm doing:
If orc file's size is small, we can use one io request to load it
What I'm doing:
Support it
Fix https://github.com/StarRocks/StarRocksTest/issues/6250
What type of PR is this:
- [ ] BugFix
- [ ] Feature
- [x] Enhancement
- [ ] Refactor
- [ ] UT
- [ ] Doc
- [ ] Tool
Does this PR entail a change in behavior?
- [ ] Yes, this PR will result in a change in behavior.
- [x] No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
- [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
- [ ] Parameter changes: default values, similar parameters but with different default values
- [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
- [ ] Feature removed
- [ ] Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
- [ ] I have added test cases for my bug fix or my new feature
- [ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
- [ ] This is a backport pr
Bugfix cherry-pick branch check:
- [x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.2
- [x] 3.1
- [x] 3.0
- [ ] 2.5
[FE Incremental Coverage Report]
:white_check_mark: pass : 0 / 0 (0%)
[BE Incremental Coverage Report]
:white_check_mark: pass : 14 / 16 (87.50%)
file detail
path | covered_line | new_line | coverage | not_covered_line_detail | |
---|---|---|---|---|---|
:large_blue_circle: | be/src/exec/orc_scanner.cpp | 14 | 16 | 87.50% | [202, 204] |
@Mergifyio backport branch-3.2
backport branch-3.2
✅ Backports have been created
-
#41856 [Enhancement] Optimize broker load small orc files (backport #41765) has been created for branch
branch-3.2
@Smith-Cruise How about other file format, like Parquet, CSV? Is the 8MB tested?
@Smith-Cruise How about other file format, like Parquet, CSV? Is the 8MB tested?
Only optimized for ORC.
CSV we don't need to optimize, because our minimal io request size is 8MB, it's big enough.