starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Fix bug which cause storage volume is shown unexpectedly

Open TszKitLo40 opened this issue 1 year ago • 3 comments

Why I'm doing:

The system database information_schema and sys is not bind to storage volume. But in show create db statement, it will show it has been bind to storage volume.

mysql> show create database information_schema;
+--------------------+-----------------------------------------------------------------------------------------------+
| Database           | Create Database                                                                               |
+--------------------+-----------------------------------------------------------------------------------------------+
| information_schema | CREATE DATABASE `information_schema`
PROPERTIES ("storage_volume" = "builtin_storage_volume") |
+--------------------+-----------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

What I'm doing:

Fix bug which cause storage volume is shown unexpectedly.

mysql> show create database information_schema;
+--------------------+--------------------------------------+
| Database           | Create Database                      |
+--------------------+--------------------------------------+
| information_schema | CREATE DATABASE `information_schema` |
+--------------------+--------------------------------------+
1 row in set (0.01 sec)

Fixes #issue

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [x] 3.2
    • [x] 3.1
    • [ ] 3.0
    • [ ] 2.5

TszKitLo40 avatar Feb 27 '24 06:02 TszKitLo40

[FE Incremental Coverage Report]

:white_check_mark: pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/qe/ShowExecutor.java 1 1 100.00% []

github-actions[bot] avatar Feb 29 '24 09:02 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Feb 29 '24 09:02 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar Mar 04 '24 07:03 github-actions[bot]

@Mergifyio backport branch-3.1

github-actions[bot] avatar Mar 04 '24 07:03 github-actions[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar Mar 04 '24 07:03 mergify[bot]

backport branch-3.1

✅ Backports have been created

mergify[bot] avatar Mar 04 '24 07:03 mergify[bot]

backport 3.1: https://github.com/StarRocks/starrocks/pull/42057

TszKitLo40 avatar Mar 07 '24 01:03 TszKitLo40