starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[WIP] [Feature] support config starlet memory size bytes

Open starrocks-xupeng opened this issue 1 year ago • 2 comments

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [x] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

starrocks-xupeng avatar Feb 26 '24 09:02 starrocks-xupeng

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] avatar Mar 07 '24 09:03 github-actions[bot]

[BE Incremental Coverage Report]

:x: fail : 6 / 14 (42.86%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/http/action/update_config_action.cpp 0 4 00.00% [161, 162, 163, 164]
:large_blue_circle: be/src/service/staros_worker.cpp 6 10 60.00% [412, 413, 419, 420]

github-actions[bot] avatar Mar 07 '24 09:03 github-actions[bot]