starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Ngram bloom filter support like predicate and case_insensitive mode

Open before-Sunrise opened this issue 1 year ago • 3 comments

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [x] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [ ] Yes, this PR will result in a change in behavior.
  • [x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
  • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [x] I have checked the version labels which the pr will be auto-backported to the target branch
    • [ ] 3.2
    • [ ] 3.1
    • [ ] 3.0
    • [ ] 2.5

before-Sunrise avatar Feb 25 '24 13:02 before-Sunrise

[FE Incremental Coverage Report]

:white_check_mark: pass : 13 / 13 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/common/NgramBfIndexParamsKey.java 2 2 100.00% []
:large_blue_circle: com/starrocks/analysis/BloomFilterIndexUtil.java 10 10 100.00% []
:large_blue_circle: com/starrocks/common/FeConstants.java 1 1 100.00% []

github-actions[bot] avatar Mar 04 '24 13:03 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 116 / 134 (86.57%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/storage/column_predicate.h 0 2 00.00% [170, 171]
:large_blue_circle: be/src/exprs/function_call_expr.cpp 72 86 83.72% [203, 216, 225, 254, 260, 279, 294, 303, 317, 318, 319, 326, 327, 343]
:large_blue_circle: be/src/storage/rowset/bloom_filter_index_writer.cpp 6 7 85.71% [203]
:large_blue_circle: be/src/storage/rowset/column_reader.cpp 10 11 90.91% [697]
:large_blue_circle: be/src/storage/schema_change_utils.cpp 4 4 100.00% []
:large_blue_circle: be/src/storage/rowset/column_writer.cpp 4 4 100.00% []
:large_blue_circle: be/src/storage/column_expr_predicate.cpp 2 2 100.00% []
:large_blue_circle: be/src/exprs/expr.cpp 2 2 100.00% []
:large_blue_circle: be/src/exprs/expr_context.cpp 2 2 100.00% []
:large_blue_circle: be/src/exprs/function_context.h 1 1 100.00% []
:large_blue_circle: be/src/storage/metadata_util.cpp 1 1 100.00% []
:large_blue_circle: be/src/storage/rowset/bloom_filter.h 1 1 100.00% []
:large_blue_circle: be/src/util/slice.h 4 4 100.00% []
:large_blue_circle: be/src/exprs/ngram.cpp 7 7 100.00% []

github-actions[bot] avatar Mar 04 '24 14:03 github-actions[bot]