starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[Enhancement] Add build host distributor into FE/BE version info

Open kevincai opened this issue 1 year ago • 3 comments

  • add 'Build distributor id' info into fe/be version info
  • be able to known which distributor id the artifacts is built on

Why I'm doing:

What I'm doing:

Example output with this PR:

  • FE
root@f79358a72f0a:~/starrocks/output# ./fe/bin/show_fe_version.sh 
Build version: 1.2.3
Commit hash: 19763c8
Build type: RELEASE
Build time: 2024-02-20 13:13:27
Build user: StarRocks@docker-ubuntu
Build distributor id: ubuntu
Java compile version: openjdk full version "11.0.20.1+1-post-Ubuntu-0ubuntu122.04"
  • BE
root@f79358a72f0a:~/starrocks/output# ./be/bin/show_be_version.sh 
1.2.3-19763c8
BuildType: RELEASE
Built on 2024-02-20 13:01:41 by StarRocks@docker-ubuntu
Build distributor id: ubuntu

Fixes #issue

What type of PR is this:

  • [ ] BugFix
  • [ ] Feature
  • [X] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Does this PR entail a change in behavior?

  • [x] Yes, this PR will result in a change in behavior.
  • [ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • [ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • [ ] Parameter changes: default values, similar parameters but with different default values
  • [ ] Policy changes: use new policy to replace old one, functionality automatically enabled
  • [ ] Feature removed
  • [X] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
    • [ ] I have added documentation for my new feature or new function
  • [ ] This is a backport pr

Bugfix cherry-pick branch check:

  • [X] I have checked the version labels which the pr will be auto-backported to the target branch
    • [X] 3.2
    • [X] 3.1
    • [X] 3.0
    • [X] 2.5

kevincai avatar Feb 20 '24 09:02 kevincai

appended the description information to the build host. An example is as the follows

root@f221cc40947e:~/starrocks/output# ./fe/bin/show_fe_version.sh
Build version: build_id
Commit hash: 1bd2705
Build type: RELEASE
Build time: 2024-02-28 08:52:43
Build distributor id: ubuntu
Build user: StarRocks@docker (Ubuntu 22.04.3 LTS)
Java compile version: openjdk full version "11.0.20.1+1-post-Ubuntu-0ubuntu122.04"

root@f221cc40947e:~/starrocks/output# ./be/bin/show_be_version.sh
build_id-1bd2705
BuildType: RELEASE
Build distributor id: ubuntu
Built on 2024-02-28 08:27:35 by StarRocks@docker (Ubuntu 22.04.3 LTS)

@chaoyli please take a look if this is good enough for now.

kevincai avatar Feb 28 '24 09:02 kevincai

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

sonarqubecloud[bot] avatar Feb 28 '24 09:02 sonarqubecloud[bot]

[FE Incremental Coverage Report]

:x: fail : 0 / 2 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/StarRocksFE.java 0 2 00.00% [112, 337]

github-actions[bot] avatar Feb 28 '24 10:02 github-actions[bot]

[BE Incremental Coverage Report]

:white_check_mark: pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/util/debug_util.cpp 1 1 100.00% []

github-actions[bot] avatar Feb 28 '24 10:02 github-actions[bot]

@Mergifyio backport branch-3.2

github-actions[bot] avatar Feb 29 '24 00:02 github-actions[bot]

@Mergifyio backport branch-3.1

github-actions[bot] avatar Feb 29 '24 00:02 github-actions[bot]

@Mergifyio backport branch-3.0

github-actions[bot] avatar Feb 29 '24 00:02 github-actions[bot]

@Mergifyio backport branch-2.5

github-actions[bot] avatar Feb 29 '24 00:02 github-actions[bot]

backport branch-3.2

✅ Backports have been created

mergify[bot] avatar Feb 29 '24 00:02 mergify[bot]

backport branch-3.1

✅ Backports have been created

mergify[bot] avatar Feb 29 '24 00:02 mergify[bot]

backport branch-3.0

✅ Backports have been created

mergify[bot] avatar Feb 29 '24 00:02 mergify[bot]

backport branch-2.5

✅ Backports have been created

mergify[bot] avatar Feb 29 '24 00:02 mergify[bot]

give up backport to branch-2.5

kevincai avatar Feb 29 '24 02:02 kevincai