starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Routine load name with backquotes

Open rickif opened this issue 3 years ago • 4 comments

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Which issues of this PR fixes :

Fixes https://github.com/StarRocks/starrocks/issues/11550

Problem Summary(Required) :

The new parser cannot handle the identifiers with backquotes. This PR is to fix the problem and keep compatible with old versions.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

rickif avatar Sep 22 '22 09:09 rickif

@mergifyio backport branch-2.4

rickif avatar Sep 23 '22 14:09 rickif

backport branch-2.4

✅ Backports have been created

mergify[bot] avatar Sep 23 '22 14:09 mergify[bot]

run starrocks_fe_unittest

rickif avatar Sep 26 '22 07:09 rickif

[FE PR Coverage Check]

:disappointed: fail : 8 / 11 (72.73%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/analysis/ShowRoutineLoadTaskStmt.java 1 2 50.00% [91]
:large_blue_circle: com/starrocks/sql/parser/AstBuilder.java 7 9 77.78% [1809, 1813]

wanpengfei-git avatar Sep 26 '22 07:09 wanpengfei-git

run starrocks_admit_test

wanpengfei-git avatar Sep 28 '22 13:09 wanpengfei-git