starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

Published 20 hours ago • verified publisher icon StarRocks

[Feature] new privilege framework: new image formatter

Open padmejin opened this issue 3 years ago • 2 comments
trafficstars

What type of PR is this：

  • [ ] BugFix
  • [x] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

Introduce a new privilege framework. To avoid huge PR which is hard to review and easy to conflict, I'm splitting into several small PR, each implementing an individual aspect of the new privilege framework. This is the second one. For previous PRs see

  • https://github.com/StarRocks/starrocks/pull/11447

This PR implements a new format of image and uses this format to persist the AuthenticationManager class.

Checklist:

  • [x] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

padmejin avatar Sep 22 '22 05:09 padmejin

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 26 '22 08:09 sonarqubecloud[bot]

[FE PR Coverage Check]

:heart_eyes: pass : 120 / 138 (86.96%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/server/GlobalStateMgr.java 0 8 00.00% [1225, 1312, 1313, 1315, 1477, 1522, 1523, 1525]
:large_blue_circle: com/starrocks/authentication/AuthenticationManager.java 33 41 80.49% [217, 218, 219, 220, 243, 244, 251, 252]
:large_blue_circle: com/starrocks/persist/metablock/SRMetaBlockReader.java 35 37 94.59% [99, 100]
:large_blue_circle: com/starrocks/persist/metablock/SRMetaBlockException.java 2 2 100.00% []
:large_blue_circle: com/starrocks/persist/metablock/SRMetaBlockWriter.java 21 21 100.00% []
:large_blue_circle: com/starrocks/common/io/Text.java 16 16 100.00% []
:large_blue_circle: com/starrocks/persist/metablock/SRMetaBlockEOFException.java 2 2 100.00% []
:large_blue_circle: com/starrocks/authentication/UserAuthenticationInfo.java 1 1 100.00% []
:large_blue_circle: com/starrocks/persist/metablock/SRMetaBlockFooter.java 4 4 100.00% []
:large_blue_circle: com/starrocks/persist/metablock/SRMetaBlockHeader.java 6 6 100.00% []

wanpengfei-git avatar Sep 26 '22 08:09 wanpengfei-git

run starrocks_admit_test

wanpengfei-git avatar Sep 27 '22 01:09 wanpengfei-git