starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

Published 20 hours ago • verified publisher icon StarRocks

[Feature] Support ssl for mysql protocol

Open gengjun-git opened this issue 3 years ago • 7 comments

What type of PR is this：

  • [ ] BugFix
  • [x] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

This PR provides the ssl interface framework. Users can implement SSLChannel to support ssl encryption.

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

gengjun-git avatar Sep 20 '22 09:09 gengjun-git

run starrocks_admit_test

gengjun-git avatar Sep 21 '22 06:09 gengjun-git

run starrocks_admit_test

wanpengfei-git avatar Sep 21 '22 07:09 wanpengfei-git

run starrocks_admit_test

wanpengfei-git avatar Sep 21 '22 09:09 wanpengfei-git

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 21 '22 09:09 sonarqubecloud[bot]

[FE PR Coverage Check]

:disappointed: fail : 52 / 117 (44.44%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/mysql/ssl/SSLChannelImpClassLoader.java 0 17 00.00% [14, 15, 17, 22, 23, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39]
:large_blue_circle: com/starrocks/qe/QeService.java 4 15 26.67% [48, 49, 54, 75, 76, 77, 79, 80, 82, 83, 84]
:large_blue_circle: com/starrocks/mysql/MysqlChannel.java 12 31 38.71% [131, 134, 139, 140, 144, 145, 147, 148, 149, 150, 153, 154, 155, 156, 157, 158, 163, 199, 242]
:large_blue_circle: com/starrocks/mysql/MysqlProto.java 10 24 41.67% [113, 114, 115, 116, 117, 118, 120, 124, 125, 126, 212, 216, 217, 218]
:large_blue_circle: com/starrocks/mysql/MysqlHandshakePacket.java 3 5 60.00% [76, 77]
:large_blue_circle: com/starrocks/mysql/MysqlAuthPacket.java 2 3 66.67% [89]
:large_blue_circle: com/starrocks/qe/ConnectContext.java 6 7 85.71% [599]
:large_blue_circle: com/starrocks/mysql/nio/AcceptListener.java 3 3 100.00% []
:large_blue_circle: com/starrocks/common/Config.java 3 3 100.00% []
:large_blue_circle: com/starrocks/common/ErrorCode.java 1 1 100.00% []
:large_blue_circle: com/starrocks/mysql/nio/NMysqlServer.java 2 2 100.00% []
:large_blue_circle: com/starrocks/mysql/MysqlCapability.java 1 1 100.00% []
:large_blue_circle: com/starrocks/mysql/nio/NConnectContext.java 1 1 100.00% []
:large_blue_circle: com/starrocks/mysql/nio/NMysqlChannel.java 1 1 100.00% []
:large_blue_circle: com/starrocks/mysql/MysqlServer.java 3 3 100.00% []

wanpengfei-git avatar Sep 21 '22 09:09 wanpengfei-git

run starrocks_admit_test

gengjun-git avatar Sep 22 '22 08:09 gengjun-git

run starrocks_admit_test

gengjun-git avatar Sep 22 '22 08:09 gengjun-git