starrocks icon indicating copy to clipboard operation
starrocks copied to clipboard

[BugFix] Fix export close file fail bug

Open xiaoyong-z opened this issue 1 year ago • 7 comments

Signed-off-by: xyz [email protected]

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Which issues of this PR fixes :

Fixes #11183

Problem Summary(Required) :

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] I have added user document for my new feature or new function

If an error occurs in export, such as PlainTextBuilder init fail because of No CSV converter for type OBJECT, the export will return from BE to FE immediately, and FE will clean the temp dir. At the same time, BE will close the temp file in temp dir. if unfortunately, the temporary file to be closed has already been deleted, it will report that the close file is deleted error msgs.

In this pr, we will return to FE until we close all temp files.

xiaoyong-z avatar Sep 14 '22 07:09 xiaoyong-z

run starrocks_fe_unittest

xiaoyong-z avatar Sep 17 '22 10:09 xiaoyong-z

[FE PR Coverage Check]

:disappointed: fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/fs/hdfs/HdfsFsManager.java 0 1 00.00% [1019]

wanpengfei-git avatar Sep 17 '22 10:09 wanpengfei-git

run starrocks_admit_test

wanpengfei-git avatar Sep 20 '22 02:09 wanpengfei-git

run starrocks_admit_test

xiaoyong-z avatar Sep 20 '22 07:09 xiaoyong-z

run starrocks_admit_test

xiaoyong-z avatar Sep 21 '22 02:09 xiaoyong-z

run starrocks_admit_test

wanpengfei-git avatar Sep 21 '22 12:09 wanpengfei-git