starrocks-kubernetes-operator icon indicating copy to clipboard operation
starrocks-kubernetes-operator copied to clipboard

Allow using milliCPU notation for resource requests rather than integer string

Open inviscid opened this issue 1 year ago • 2 comments

Describe the current behavior

Currently, resource requests are required to be integer strings. Attempting to use milliCPU notation fails.

This works:

starrocks:
  cn:
    cpu: '1'
    memory: 4Gi
    replicas: 1
  fe:
    cpu: '1'
    memory: 4Gi
    replicas: 3

This does not:

starrocks:
  cn:
    cpu: 500m
    memory: 4Gi
    replicas: 1
  fe:
    cpu: 500m
    memory: 4Gi
    replicas: 3

Describe the enhancement

Allow use of milliCPU notation and pass through to the underlying statefulset and pod resource requests as specified.

Additional context

N/A

inviscid avatar Jan 11 '24 04:01 inviscid

Operator has supported milliCPU from the beginning. What version is your Operator, and what error did it report? This is from StarRocksCluster CR.

    limits:
      cpu: 2
      memory: 4Gi
    requests:
      cpu: 100m
      memory: 200Mi

yandongxiao avatar Jan 11 '24 05:01 yandongxiao

‌‌I believe the operator has already supported this requirement. I will now close this issue. If your problem has not been resolved, please reopen it.

yandongxiao avatar May 30 '24 02:05 yandongxiao