starrocks-connector-for-apache-flink icon indicating copy to clipboard operation
starrocks-connector-for-apache-flink copied to clipboard

[#367][BugFix]enhance unqualified load-url config validate and test

Open xumanbu opened this issue 8 months ago • 2 comments

What type of PR is this:

  • [x] BugFix
  • [ ] Feature
  • [ ] Enhancement
  • [ ] Refactor
  • [ ] UT
  • [ ] Doc
  • [ ] Tool

Which issues of this PR fixes :

Fixes #367

Problem Summary(Required) :

  1. defaultStreamLoader#testHttpConnection catched all Exception at now, wo can catch MalformedURLException and throw an IllegalArgumentException.

  2. fix StarRocksSinkOptions#validateStreamLoadUrl host spilt check logic

Checklist:

  • [ ] I have added test cases for my bug fix or my new feature
  • [ ] This pr will affect users' behaviors
  • [ ] This pr needs user documentation (for new or modified features or behaviors)
  • [ ] I have added documentation for my new feature or new function

xumanbu avatar Jun 21 '24 04:06 xumanbu