bevy_ecs_tilemap icon indicating copy to clipboard operation
bevy_ecs_tilemap copied to clipboard

Update to Bevy 0.8

Open neocturne opened this issue 3 years ago • 7 comments

This updates all Rust and shader code to work with Bevy 0.8. All examples seem to work fine on my system (Linux Wayland, tested with --features bevy/wayland because of https://github.com/bevyengine/bevy/issues/5524).

neocturne avatar Aug 01 '22 18:08 neocturne

What platform did you test this on? I'm fairly certain it wont work on vulkan due to a WGPU bug.

StarArawn avatar Aug 01 '22 18:08 StarArawn

What platform did you test this on? I'm fairly certain it wont work on vulkan due to a WGPU bug.

Interesting, do you have a link to a bug report?

It seems to work on my machine with Vulkan (as mentioned, I'm on Linux/Wayland):

AdapterInfo { name: "AMD RADV RENOIR", vendor: 4098, device: 5686, device_type: IntegratedGpu, backend: Vulkan }

neocturne avatar Aug 01 '22 20:08 neocturne

What platform did you test this on? I'm fairly certain it wont work on vulkan due to a WGPU bug.

Interesting, do you have a link to a bug report?

It seems to work on my machine with Vulkan (as mentioned, I'm on Linux/Wayland):

AdapterInfo { name: "AMD RADV RENOIR", vendor: 4098, device: 5686, device_type: IntegratedGpu, backend: Vulkan }

Huh, it might be a windows only thing. Here is the issue I uncovered: https://github.com/gfx-rs/naga/issues/2018

I tested this branch specifically and it does not work for me in windows 11, vulkan, and geforce driver 511.79. Dx12 works however.

StarArawn avatar Aug 02 '22 11:08 StarArawn

Tested this on Windows 10 with Vulkan backend:

AdapterInfo { name: "NVIDIA GeForce RTX 2070", vendor: 4318, device: 7956, device_type: DiscreteGpu, backend: Vulkan }

Works great, no issues so far.

mbolt35 avatar Aug 03 '22 18:08 mbolt35

Tested this on Windows 10 with Vulkan backend:

AdapterInfo { name: "NVIDIA GeForce RTX 2070", vendor: 4318, device: 7956, device_type: DiscreteGpu, backend: Vulkan }

Works great, no issues so far.

Yeah, I discovered the issue was due to a driver bug. Updating my drivers resolved the issue. I likely still wont merge this as we are fairly close to merging the rewrite branch into master and releasing a new version.

StarArawn avatar Aug 03 '22 18:08 StarArawn

Yeah, I discovered the issue was due to a driver bug. Updating my drivers resolved the issue. I likely still wont merge this as we are fairly close to merging the rewrite branch into master and releasing a new version.

Awesome! Looking forward to the changes in rewrite. Just to confirm, the rewrite branch has support for bevy 0.8?

mbolt35 avatar Aug 03 '22 19:08 mbolt35

Awesome! Looking forward to the changes in rewrite. Just to confirm, the rewrite branch has support for bevy 0.8?

Correct! Most of the work is done for the rewrite. I'm mostly working on cleaning up docs.

StarArawn avatar Aug 03 '22 19:08 StarArawn