bevy_ecs_tilemap
bevy_ecs_tilemap copied to clipboard
StarArawn
Add Basic CI
This includes
- Checking the quality of the code with Clippy.
- Running Cargo test on Windows, MacOS, and Ubuntu.
For an example of how this looks in practice, check out the results from the fork here for Clippy and here for running cargo test.
Currently, the CI running cargo test is having some issues with the examples provided in the documentation. Should these examples be fixed, or ignored?
Currently, the CI running cargo test is having some issues with the examples provided in the documentation. Should these examples be fixed, or ignored?
I'm not sure how I feel about clippy since it makes some code quality suggestions I'm not sure I agree with. Also it would take a bit of time to configure it how I would like. I don't think we should be running any tests since this library doesn't really have any tests worth running.
In one of my other projects I do run a light cargo format check. I could see that being helpful here: https://github.com/StarArawn/kayak_ui/blob/main/.github/workflows/rust.yml
Okay, that sounds reasonable. Based on your feedback, I replaced the call to run tests to just check the code for all targets, and made the code quality workflow run the light cargo format check from your project. I also made the dependencies and workflow triggers consistent from the project to this CI.
How does this look for code quality, and for the CI?
Hey @StarArawn, congratulations for getting through the recent rewrite! I was wondering if you'd still be interested in this feature.
We are still interested in this :) I'm going to push up a couple changes here with @bzm3r.
I couldn't get pushing to your branch working, so I continued this in #248. Thanks!