gnss_lib_py icon indicating copy to clipboard operation
gnss_lib_py copied to clipboard

Option for fast load. Default is true

Open inuex35 opened this issue 8 months ago • 4 comments

Fast load is enabled for rinex 40 min -> 40 sec with georinex develop branch

inuex35 avatar Mar 30 '25 06:03 inuex35

@inuex35 can I get some additional context on your desired change?

It looks like in the main branch of georinex, fast already defaults to true? https://github.com/geospace-code/georinex/blob/729b85af584153ac052e81e7652e145c5a5ebb9c/src/georinex/base.py#L29

betaBison avatar Apr 06 '25 02:04 betaBison

Hi this is for rinex ver3, it looks main branch has not supported fast load with version 3 yet. I left this PR for someone who is looking for fast processing for rinex version 3. https://github.com/geospace-code/georinex/commit/57b74e0100f3056a3101ed6c0f817be34b099364

inuex35 avatar Apr 06 '25 02:04 inuex35

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.66%. Comparing base (880bbf7) to head (7ee7658).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          27       27           
  Lines        3883     3883           
=======================================
  Hits         3870     3870           
  Misses         13       13           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 06 '25 02:04 codecov[bot]

Got it, thanks. We'll wait until those changes get filtered up into georinex main and a new version is released on pypi so we can correctly tag it in our dependency requirements. I saw you were making some changes to the georinex repo yourself too. I was able to get code pulled into main by making a pull request and tagging the main maintainer. It just took a very, very, very long time for them to approve it and merge.

Thanks for using glp!

betaBison avatar Apr 06 '25 03:04 betaBison