GREA icon indicating copy to clipboard operation
GREA copied to clipboard

Added Column Classes Panel

Open ben-schwen opened this issue 5 years ago • 2 comments

Hey Stan,

I added a new panel to let the user manually select his column classes out of a dropdown menu. Since I also wanted to bound these values, I had to use 'rhandsontable'.

cheers, Ben

ben-schwen avatar Jul 09 '19 09:07 ben-schwen

Hey Ben,

nice job. Good idea. There are two small points remaining, however:

  • It's not possible to do vertical scrolling on the data types handsontable. Horizontal Scrolling works
  • There seems to be a bug with making the correct R code for display on the console. Try importing inst/extdata/excel_aachen.xlsx and leaving all column classes as is. Then the following code is pasted into the console: Screenshot 2019-07-12 at 16 29 01

Best, Stani

Stan125 avatar Jul 12 '19 14:07 Stan125

Hey Stani,

I reworked the code to be more consistent with your style. Now I add an additional argument to the read function instead of "hacking" the expr string on the end.

The two points you mentioned are cleared.

I also added a "Reload" button to the columns tab to give the possibility to reload the isolated data. This also added the following features:

  • column types are only added, if you visit the "Data Types" tab at least once
  • reload possibility of the dataset since it had to be isolated to save the changes from the handsontable edit
  • possibility to use similar code to also let the user the column names and not only the types

cheers Ben

ben-schwen avatar Jul 12 '19 23:07 ben-schwen