[3.0dev5] Console Error - window.controllers/Controllers is deprecated

[LindsayHill]

This message is logged in the Console on Firefox 63.0.3:

window.controllers/Controllers is deprecated. Do not use it for UA detection.

package.json has this "brace": "0.8.0"

The underlying ace package fixes this here. I believe that was in ace 1.3.0.

brace currently uses ace 1.2.9. Looks like development has stalled on brace, and is not merging PR to go to ace 1.4.1. May need to reconsider use of brace.

[bigmstone]

I dug into this a while back. Brace hasn't had a release in ~1 year. There's a PR to bump ace version that remains unmerged. It's not a fantastic situation.

See: https://github.com/securingsincity/react-ace/issues/512 https://github.com/thlorenz/brace/pull/139

We will need to triage what options we have, but this is low priority since the change will likely be high touch point, and reward is minimal.

[bmomberger-bitovi]

Verified that the deprecation message still exists on Firefox 65