st2 icon indicating copy to clipboard operation
st2 copied to clipboard

add missing api.max_page_size to config as IntOpt

Open maxfactor1 opened this issue 1 year ago • 6 comments

Background

This is a minor fix request to add the 'api.max_page_size' option to the config

Overview of this PR

This request allows the api.max_page_size config option to be used as intended by expressly defining the option, and a default value of '100' in config. Fix submitted to resolve issue #5327

maxfactor1 avatar Feb 13 '24 16:02 maxfactor1

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: maxfactor1
:x: Maxwell Buehler


Maxwell Buehler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 13 '24 16:02 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: maxfactor1
:x: Maxwell Buehler


Maxwell Buehler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 13 '24 16:02 CLAassistant

multiple failed tests here. did you recreate the config?

guzzijones avatar Mar 07 '24 17:03 guzzijones

Honestly unsure what that's all about. The change was pretty tiny, what config would need to be re-created?

maxfactor1 avatar Mar 07 '24 18:03 maxfactor1