st2 icon indicating copy to clipboard operation
st2 copied to clipboard

remove kwarg_op from remote-shell-cmd runner?

Open minsis opened this issue 4 years ago • 1 comments

SUMMARY

Documentation shows that remote-shell-cmd accepts the kwarg_op parameter leading one to believe that its supposed to work like remote-shell-script runners. After some time of fighting this I finally dug into source and noticed that remote-shell-cmd doesn't even attempt to build an args list like the shell runner does.

I dont know if this is a bug or if it was never intended to build an args list. Either way, code needs to fix it or the docs should be updated to not support kwarg_op since its not even used.

https://docs.stackstorm.com/reference/runners.html?remote-command-runner-remote-shell-cmd#remote-command-runner-remote-shell-cmd

STACKSTORM VERSION

Paste the output of st2 --version: st2 3.6.0, on Python 3.6.8

Steps to reproduce the problem

Create a remote-shell-cmd action with extra params other than the default ones and execute the action.

Expected Results

The action to build on the command and add all left over action params as args

Actual Results

Extra params are ignored.

minsis avatar Dec 03 '21 20:12 minsis

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue.

stale[bot] avatar Apr 16 '22 05:04 stale[bot]