tirith icon indicating copy to clipboard operation
tirith copied to clipboard

adding Type Annotations

Open kushal9897 opened this issue 1 year ago • 4 comments

Pull Request Template

#180

Description

  • What changes are being made?

  • Why are these changes necessary?

  • Which issues or tickets does this PR close or relate to?

    • Related issue: #

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update
  • [*] Other (please specify):

Checklist

  • [*] Code has been linted.
  • [ ] Documentation has been updated (if needed).
  • [ ] Tests have been added or updated (if needed).
  • [ ] Any breaking changes have been communicated to the team.

Screenshots or Recordings (if applicable)

Additional Information

kushal9897 avatar Oct 15 '24 22:10 kushal9897

@refeed, The requested change have been successfully implemented

kushal9897 avatar Oct 22 '24 23:10 kushal9897

Thanks for pointing that out! I'll make sure to import the necessary types before using them. I'll fix the tests and update the code accordingly.

kushal9897 avatar Oct 24 '24 09:10 kushal9897

@refeed I have fixed the error. Please review it.

kushal9897 avatar Oct 24 '24 10:10 kushal9897

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Nov 06 '24 10:11 sonarqubecloud[bot]