tirith
tirith copied to clipboard
adding Type Annotations
Pull Request Template
#180
Description
-
What changes are being made?
-
Why are these changes necessary?
-
Which issues or tickets does this PR close or relate to?
- Related issue: #
Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation update
- [*] Other (please specify):
Checklist
- [*] Code has been linted.
- [ ] Documentation has been updated (if needed).
- [ ] Tests have been added or updated (if needed).
- [ ] Any breaking changes have been communicated to the team.
Screenshots or Recordings (if applicable)
Additional Information
@refeed, The requested change have been successfully implemented
Thanks for pointing that out! I'll make sure to import the necessary types before using them. I'll fix the tests and update the code accordingly.
@refeed I have fixed the error. Please review it.
Quality Gate failed
Failed conditions
C Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint