dnscontrol icon indicating copy to clipboard operation
dnscontrol copied to clipboard

HTTPS-RR `no-default-alpn` must be empty

Open Gunni opened this issue 1 month ago • 5 comments

Describe the bug For "no-default-alpn", the presentation and wire-format values be empty.

To Reproduce Steps to reproduce the behavior:

  1. Create a HTTPS("asd", 1, ".", "no-default-alpn alpn=h3,h2")
  2. Look at result on provider
  3. Observe no-default-alpn=""

Expected behavior no-default-alpn is a flag, not a key/value thing?

DNS Provider Cloudflare

Additional context "values be empty" might mean ="" is ok, it's an empty string value?

Gunni avatar Oct 29 '25 17:10 Gunni

Any thoughts, @fritterhoff @tresni ?

tlimoncelli avatar Oct 29 '25 20:10 tlimoncelli

Uff. Jep. We have to accept missing values

fritterhoff avatar Oct 30 '25 04:10 fritterhoff

Prop. we have to fix this: https://github.com/StackExchange/dnscontrol/blob/70c1febe23b624a4ed1f928b780bbc4569753fc1/models/t_svcb.go#L17-L19

fritterhoff avatar Oct 30 '25 09:10 fritterhoff

Also, the field order is irrelevant, don't modify if server has different order of fields?

Or, always use this order as if on wire?

Gunni avatar Oct 30 '25 15:10 Gunni

From my point of view we don't touch the order right now?

fritterhoff avatar Oct 31 '25 06:10 fritterhoff