dnscontrol icon indicating copy to clipboard operation
dnscontrol copied to clipboard

Fix tag filtering

Open cdhunt opened this issue 3 years ago • 1 comments

https://circleci.com/docs/workflows#executing-workflows-for-a-git-tag

cdhunt avatar Aug 10 '22 21:08 cdhunt

CC @cafferata

tlimoncelli avatar Aug 10 '22 22:08 tlimoncelli

Test the multi-arch manifest:

docker run --rm -it stackexchange/dnscontrol:v3.18.2-pre013 version

cdhunt avatar Aug 12 '22 14:08 cdhunt

One item that is unclear to me is that it looks like GoReleaser is used to create the binaries but not the Docker images. Given that it can do both and that there is evidence this was the case at one point, is there a reason not to do so?

jauderho avatar Aug 12 '22 17:08 jauderho

@jauderho It is building all artifacts including the docker images in this branch.

cdhunt avatar Aug 12 '22 17:08 cdhunt

(I'll let you do the merge)

tlimoncelli avatar Aug 12 '22 18:08 tlimoncelli

@jauderho I guess more specifically, it is basically just invoking docker buildx build -f Dockerfile . We still need a Dockerfile and instaed rebuilding everything in the docker build I just copy in the binaries that gorelease spits out. I think Goreaser does some magic to put the version of dnscontrol matching the arch in the root of dist. I need to get a colleague to test on an M1 Mac.

cdhunt avatar Aug 12 '22 18:08 cdhunt