blackbox icon indicating copy to clipboard operation
blackbox copied to clipboard

Rewrite blackbox in Go (golang)

Open TomOnTime opened this issue 5 years ago • 4 comments

This is the issue to track the development of a Go version.

CC: @hpoul @mnewswanger @MaxHorstmann @captncraig

TomOnTime avatar Jun 07 '20 22:06 TomOnTime

The "golang" branch has made a lot of progress this weekend:

  1. Reworked the subcommands and flags. More consistent. Easier to understand. Rather than one subcommand for each legacy bash script, there is often a subcommand with various flags.

  2. Plug-ins for VCS: I've written Git and "None". Adding Mercurial, Subversion, etc. should be a breeze.

  3. Plug-ins for GPG implementation: I've written one that calls out to /usr/bin/gpg. It will be easy to add support for go-openpgp, Windows gpg.exe, and others.

The code is A LOT more simple now. This is the 3rd (?) iteration of trying to simplify the code. It is a lot better than my earlier iterations. The interfaces are much better structured now. I think anyone should be able to hack on this very easily. In fact, it is so much cleaner that it requires less test code.

If you want to see the code so far, it is in this branch: https://github.com/StackExchange/blackbox/tree/golang

CC: @farseeker

TomOnTime avatar Jun 07 '20 22:06 TomOnTime

Beta implementation is in https://github.com/StackExchange/blackbox/pull/250

tlimoncelli avatar Jul 24 '20 18:07 tlimoncelli

No Go tests yet, right?

MaxHorstmann avatar Nov 11 '20 21:11 MaxHorstmann

I had to dig through some notes.

The go tests are:

Unit tests:

go test ./...

Integration tests:

cd integrationTest && rm -rf /tmp/bbhome-* && go test -long --nocleanup

Tom

On Wed, Nov 11, 2020 at 4:53 PM Max Horstmann [email protected] wrote:

No Go tests yet, right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/StackExchange/blackbox/issues/310#issuecomment-725682089, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQATHJHU37ETUYYNRDUHEDSPMBXJANCNFSM4NXWVQCA .

tlimoncelli avatar Nov 12 '20 07:11 tlimoncelli