Stacks icon indicating copy to clipboard operation
Stacks copied to clipboard

Highlight.js update + new theme classes

Open b-kelly opened this issue 3 years ago • 3 comments

This is a draft PR exploring how we might take advantage of the new classes / syntax fixes that the most recent version of highlight.js has added.

Something I'd like to explore in this PR are some possible changes to the LaTeX theme. The tex community was not terribly happy with the new syntax highlighting/theme, so they took it upon themselves to contribute better highlighting detection upstream. I'd love to support these new classes so their hard work doesn't go to waste. They have a post here with suggestions on how to incorporate some of the changes into a new theme.

Changes

I've explicitly added highlight.js as a devDependency so we can tell what version our styles are being built against. I've also added a few of the unused classes to the _stacks-code-block with a TODO comment on them, as well as a LaTeX code example to the docs.

b-kelly avatar Nov 10 '20 23:11 b-kelly

Awesome! Excited to dig into the new classes. I think this all looks super good, and TeX is improved out of the box already.

aaronshekey avatar Nov 11 '20 16:11 aaronshekey

Is this still being pursued? We (meaning the TeX.sx community) might have gone quiet about this but I don't think it's because we don't want our old color scheme back but rather out of resignation. If you are working on something and need feedback, I'm sure we'll be happy to assist.

schtandard avatar Jan 25 '22 10:01 schtandard

Deploy Preview for stacks ready!

Name Link
Latest commit aef96b95f00580f20b8f9583ab77f67834134be2
Latest deploy log https://app.netlify.com/sites/stacks/deploys/628bc9294660890009ccb3fb
Deploy Preview https://deploy-preview-551--stacks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 23 '22 17:05 netlify[bot]