stablediffusion icon indicating copy to clipboard operation
stablediffusion copied to clipboard

Alphebetize requirements and add streamlit canvas dep

Open kjerk opened this issue 2 years ago • 2 comments

Alphabetizes dependencies in requirements.txt file for humans and adds streamlit-drawable-canvas which was missing but is used here: https://github.com/Stability-AI/stablediffusion/blob/33910c386eaba78b7247ce84f313de0f2c314f61/scripts/streamlit/inpainting.py#L9

kjerk avatar Nov 24 '22 11:11 kjerk

could you maybe add a separate optional requirements file for streamlit stuff? maybe something like requirements-app.txt, requirements-streamlit.txt, requirements-demo.txt, etc.

dmarx avatar Dec 06 '22 18:12 dmarx

could you maybe add a separate optional requirements file for streamlit stuff? maybe something like requirements-app.txt, requirements-streamlit.txt, requirements-demo.txt, etc.

Okay so bearing your comment in mind, and looking at the requirements/env files again it looks like they've had an update in the meanwhile, so I've updated the PR to be the following set of changes. Some of the dependencies have drifted between the Conda and Pip files as well, so updated those at the same time.

Let me know what you think about this overall strat.

Change set

  • Extract Gradio and Streamlit deps to requirements-app.txt file and remove those from requirements.txt and environment.yaml both.
  • Sort requirements.txt and environment.yaml, to help spot the desync issue below 😅
  • Update readme.md with note in requirements section about Application dependencies, and update formatting from commandline to bash for syntax highlighting.

Dependencies sync:

  • Update albumentations to 1.3.0 in requirements.txt from yaml (highest ver)
  • Set opencv-python to 4.6.0.66 in pip file, per yaml (ver was unset)
  • Set streamlit version to 1.12.1 per yaml (highest ver)
  • Set open-clip-torch version to 2.7.0 per requirements.txt (highest ver)

In concert these changes to the dependencies files look like this, top row before, bottom row after: stablediffusion_pr_21_BeforeAfter

kjerk avatar Dec 06 '22 19:12 kjerk