api-interfaces icon indicating copy to clipboard operation
api-interfaces copied to clipboard

API additions to support animation

Open pharmapsychotic opened this issue 2 years ago • 1 comments

Draft pull request as requested. This is WIP on protocol additions to enable animation pipeline.

pharmapsychotic avatar Sep 27 '22 15:09 pharmapsychotic

  • The transform sequence has been removed and ChainRequest is used instead now that it is available.
  • Warp2d and Warp3d have been replaced by TransformResample which can achieve both based on matrix and settings. No longer have fields like translate_x, translate_y, translate_z and magic values on server side. Now the client controls the coordinate system and transform entirely by passing in column major 3x3 or 4x4 matrix.
  • Several transform ops have been removed. Previously had an add_noise which was replaced by init_noise_scale, TransformWarpFlow has moved into extras since it is a temporary implementation waiting on future server side processing of init videos.
  • New extras field in request set to 2047 (max 2 byte field id). While iterating in development data can be passed here then when stable and ready promoted to proper messages in the proto before going to production.
  • Bonus script to update generated code from protos using the Docker image

pharmapsychotic avatar Dec 15 '22 23:12 pharmapsychotic

@pharmapsychotic Rebase this on main, regenerate the stubs, and we're good here - I'll merge. Ping me on Slack when done.

wbrown avatar Jan 12 '23 16:01 wbrown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jan 13 '23 19:01 sonarqubecloud[bot]