Christian Baars

Results 25 comments of Christian Baars

Please don‘t feel demotivated, your effort is highly appreciated. All the other documents are correct findings. It was just this one outlier. I am not an active HA user myself...

In line 1911: ` if(pNCharacteristic->subscribe(true, BLE_ESP32::BLEGenNotifyCB)) {` You try to subscribe to an indication and not a notification. Is this intended?

Ahh, no ... it is the opposite. forget it.

But at least in 1911 an incomplete function signature is used - missing the `response`. IDK if this is a problem.

https://github.com/arendst/Tasmota/pull/24214 I can confirm the described regression and it was an obvious bug in the code. My test with this change did work.