Squirrel.Windows icon indicating copy to clipboard operation
Squirrel.Windows copied to clipboard

Leading zero in version number: App crashes with 0xc0000409 after installation and/or auto-update on Windows

Open dtanzer opened this issue 3 years ago • 1 comments

Squirrel version(s) 2.0.1 (I am using https://github.com/electron/windows-installer and AFAICS it uses this version)

Description After installing https://download.marmota.app/win32/marmota-22.03.0%20Setup.exe the app starts once, but when I want to open it from the start menu, it crashes. The windows event log contains the error "0xc0000409".

The issue seems to be caused by the leading zero in the minor version number (03 - see "Steps to recreate" below).

Steps to recreate When installing the exe as it is, the app crashes:

$ pwd
[...]/AppData/Local/marmota/app-22.03.0
$ ../marmota.exe
=> crashes

But when I just change the name of the directory where the app is installed, it works:

$ cd ..
$ mv app-22.03.0/ app-22.3.0/
$ cd app-22.3.0/
$ ../marmota.exe
=> works

Expected behavior I would expect the app to be able to start correctly when some part of the version number contains leading zeros. If starting the app ist not the right behavior, I would at least expect an error message, not a silent crash.

Actual behavior When the install directory of the app contains a leading zero in the version number, the app crashes silently. The windows event log contains the following information:

- System 
  - Provider 
   [ Name]  Application Error 
  - EventID 1000 
   [ Qualifiers]  0 
   Version 0 
   Level 2 
   Task 100 
   Opcode 0 
   Keywords 0x80000000000000 
  - TimeCreated 
   [ SystemTime]  2022-01-24T04:57:17.3374180Z 
   EventRecordID 10422 
   Correlation 
  - Execution 
   [ ProcessID]  25844 
   [ ThreadID]  0 
   Channel Application 
   Computer DESKTOP-N3O3EHF 
   Security 
- EventData 
   marmota.exe 
   22.3.0.0 
   5f70d803 
   marmota.exe 
   22.3.0.0 
   5f70d803 
   c0000409 
   0000e892 
   4de0 
   01d810dedc1af32d 
   C:\Users\busin\AppData\Local\marmota\marmota.exe 
   C:\Users\busin\AppData\Local\marmota\marmota.exe 
   3c189c8d-8908-457b-a98f-4463ca66373c 

Additional information n/a

dtanzer avatar Jan 24 '22 07:01 dtanzer

I just realized that version numbers must be semver-compliant. But still, the App should not crash silently. It would be nicer to report an error when starting - Or, even better, when installing / updating the app or even when building the application packages.

dtanzer avatar Jan 24 '22 07:01 dtanzer