Jonathan Coates

Results 486 comments of Jonathan Coates

Whilst this'd be a really neat feature to have, I'm slightly worried about thread safety. The completion generator will need to run on the server thread, so we'll probably want...

This should be fixed with #560. There's a download available [on cc.crzd.me](https://cc.crzd.me/maven/dan200/computercraft/ComputerCraft-SquidDev-CC-ComputerCraft-hotfix-turtle-destroy/). ~~or you can use [CC:Tweaked](https://minecraft.curseforge.com/projects/cc-tweaked), which also has this fix.~~ Just read your username. I don't feel I...

I'll echo Wojbie here - the commit messages do contain _some_ details, but it's quite hard to tell what something will look like. See #390 and #396 for some examples...

This seems something which would be better done as an external mod (using something like #491 ). I'd personally consider a little too "magical" to be part of base CC...

It might be worth doing `.toLowerCase(Locale.ROOT)` instead (or `Locale.ENGLISH`) so you don't get strange behaviour on non-English systems. This change should probably be made to `os.time` and `os.day` as well...

Duplicate of #435? :p --- Firstly, CC:T. My [stance has always been][cct_contributing] that it's best to submit a PR against this repository and I'll merge/cherry-pick it onto the CC:T repo....

Can you enable `logPeripheralErrors` in your config, and then attach your logs next time this occurs? This should include a bit more diagnostic information.

Thank you, that's very helpful. This appears to be an out of bounds within `World.getPendingTileEntityAt`, which is almost definitely a threading issue. I've rewritten monitors to be thread safe in...

> does he just replace his current .jar with your CI Server build one Yep! I believe it will also require an update to the client as well, so apologies...

@Wojbie Apparently I failed to test execution from places which weren't the root directory, should be fixed now. Thanks for spotting it!