plethora icon indicating copy to clipboard operation
plethora copied to clipboard

Compatibility with OpenComputers

Open JomerDev opened this issue 7 years ago • 12 comments

Is there any chance you counld make this mod compatible with OC?

Normaly it would already work with it, but since CC is in an alpha stage OC doesn't include CC compatibility for now.

JomerDev avatar Feb 23 '17 16:02 JomerDev

Just wondering if you've had a read of #16? I've not really used OC much so can't say how much use this mod would actually be.

SquidDev avatar Feb 23 '17 17:02 SquidDev

Ah, no, I didn't see that. I always thought of OC and CC as good mods to use together. For some things CC works better, others are better done in OC. Thats why I always liked the ability to have an interface between those two. This sadly doesn't work right now. I think the modules and player interaction you have right now is something that would be very usefull, in CC and OC alike

JomerDev avatar Feb 23 '17 17:02 JomerDev

Hrrmrm, I might see if can put a PR together/create an issue for OC adding back their CC compat: it would be nice to have.

I'll have another look at adding explicit for support for OC though. I'd need to have a deeper look at it all and work out how best to suit it - I guess a perfect time to play around with the mod 😄.

SquidDev avatar Feb 23 '17 17:02 SquidDev

I think they alrady know about your patch for CC and didnt add compatibility back in. But who knows

JomerDev avatar Feb 23 '17 17:02 JomerDev

ComputerCraft integration was added back to OC in MightyPirates/OpenComputers@7c761b586ed8a7fcb2d439926f46f79661967a13. I'm going to close this for now, but if there is anything which needs explicit integration, just add it here/create a new issue.

SquidDev avatar May 09 '17 10:05 SquidDev

And reopening, as most methods will not work as OC doesn't support yielding inside drivers. We will have to investigate how we can emulate this in another way.

SquidDev avatar May 09 '17 12:05 SquidDev

And apparently I forgot to press the reopen button.

SquidDev avatar Jun 10 '17 13:06 SquidDev

Forgive me for being a bit clueless about the internals of the computer mods here, but is this issue part of what would be required to have a block scanner upgrade for OpenComputers robots?

dunstad avatar Aug 21 '17 04:08 dunstad

You've heard about this issue: https://github.com/MightyPirates/OpenComputers/issues/2996, but when I came across this problem, it also caused game to crash. The crash happens on server-side, so this might be considered as a serious issue for servers with both Plethora and OpenComputers (https://github.com/NillerMedDild/Enigmatica2Expert/issues/1479). Is there a way to at least disable plethora peripherals from appearing as OC-component? Might be useful to create a separate issue for this. Here is log if you're interested

Lgmrszd avatar Jan 11 '20 16:01 Lgmrszd

Oh, that crash should have been fixed back in August, but apparently I never did a release. Woops - I'll get right on that now.

I agree that the best solution here would just be to blacklist from showing up on OpenComputers.

SquidDev avatar Jan 11 '20 20:01 SquidDev

The fix(es) should be in Plethora 1.2.3.

SquidDev avatar Jan 11 '20 21:01 SquidDev

That was fast, thank you!

Lgmrszd avatar Jan 12 '20 08:01 Lgmrszd