unreal-sqlite3 icon indicating copy to clipboard operation
unreal-sqlite3 copied to clipboard

Fix for UE4.25.1

Open RobQuistNL opened this issue 4 years ago • 6 comments

This fixed my compile errors on a UE4.25.1 build.

RobQuistNL avatar Jul 11 '20 13:07 RobQuistNL

I also added "CISQLite3" into the PublicDependencyModuleNames.AddRange of my project's Build.cs file;

PublicDependencyModuleNames.AddRange(new string[] { "Core", "CoreUObject", "Engine", "InputCore", "Json", "JsonUtilities", "CISQLite3" });

RobQuistNL avatar Jul 11 '20 13:07 RobQuistNL

Wonder why i had to change way more Datatype names when fixing the compile issues e.g.: https://github.com/ben-mkiv/unreal-sqlite3/commit/aefe459da93f6edbfed8ca21efce0eedadbc8ff6

also changed cast to castField<> https://github.com/ben-mkiv/unreal-sqlite3/commit/c492091ad3309606c42d98964091aedfc76a83f9

Have you tested your changes yet, as i couldn't, so haven't made a PR yet. (also on which platform did you compile, maybe thats why i got more cmake errors)

ben-mkiv avatar Jul 12 '20 11:07 ben-mkiv

I have it running on my 4.25.1 Source Built - using VS17 on a Windows 10 machine.

RobQuistNL avatar Jul 12 '20 15:07 RobQuistNL

Hey everyone! @RobQuistNL @ben-mkiv

Sorry for the silence, I haven't used UE4 since half a year, since I moved to building a custom engine and am working on web based projects.

Hence, time for this is pretty limitied, but I will give this a very rough review code wise.

Best, Jonathan

Squareys avatar Aug 10 '20 09:08 Squareys

For anyone landing here:

These changes fix the plugin for UE4.25.1 on Windows, tested on Windows only. Feel free to take over and validate other platforms, then eventually this MR can be merged :)

Squareys avatar Aug 11 '20 18:08 Squareys

@Squareys pushed some changes (and reverted the random whitespace change)

RobQuistNL avatar Aug 16 '20 23:08 RobQuistNL