unreal-sqlite3
unreal-sqlite3 copied to clipboard
Fix for UE4.25.1
This fixed my compile errors on a UE4.25.1 build.
I also added "CISQLite3"
into the PublicDependencyModuleNames.AddRange
of my project's Build.cs
file;
PublicDependencyModuleNames.AddRange(new string[] { "Core", "CoreUObject", "Engine", "InputCore", "Json", "JsonUtilities", "CISQLite3" });
Wonder why i had to change way more Datatype names when fixing the compile issues e.g.: https://github.com/ben-mkiv/unreal-sqlite3/commit/aefe459da93f6edbfed8ca21efce0eedadbc8ff6
also changed cast to castField<> https://github.com/ben-mkiv/unreal-sqlite3/commit/c492091ad3309606c42d98964091aedfc76a83f9
Have you tested your changes yet, as i couldn't, so haven't made a PR yet. (also on which platform did you compile, maybe thats why i got more cmake errors)
I have it running on my 4.25.1 Source Built - using VS17 on a Windows 10 machine.
Hey everyone! @RobQuistNL @ben-mkiv
Sorry for the silence, I haven't used UE4 since half a year, since I moved to building a custom engine and am working on web based projects.
Hence, time for this is pretty limitied, but I will give this a very rough review code wise.
Best, Jonathan
For anyone landing here:
These changes fix the plugin for UE4.25.1 on Windows, tested on Windows only. Feel free to take over and validate other platforms, then eventually this MR can be merged :)
@Squareys pushed some changes (and reverted the random whitespace change)