BuildingApplicationWithSpec2 icon indicating copy to clipboard operation
BuildingApplicationWithSpec2 copied to clipboard

iconManager: is mentioned but declared as "TOREMOVE" in Spec P13

Open astares opened this issue 1 year ago • 6 comments

The book mentions #iconManager: in chapter 3.7 to set a custom icon manager - but this setter method is in category "TOREMOVE" in Pharo 13 and there is no sender of the getter method #iconManager

astares avatar Jul 03 '24 14:07 astares

Hi @astares,

Thank you for the feedback. However, in the latest builds of the PDF, I do not find iconManager: anymore. Could you tell us which version (i.e. date) of the PDF you have? You find the date on the page with the book title.

We are in the process of finalizing the book for Spec 2.0. A lot has changed or improved. We use Pharo 12 as the basis for the code examples and the explanation.

koendehondt avatar Jul 03 '24 15:07 koendehondt

@koendehondt

  • Situation for #iconManager getter/setter is the same in Pharo 12 and Pharo 13
  • Date of books PDF build is from yesterday (July 2, 2024)

astares avatar Jul 03 '24 15:07 astares

Latest build PDF

From https://objects.githubusercontent.com/github-production-release-asset-2e65be/187995713/de76b2ed-3439-4cd2-9107-2a16cdc5a293?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240703%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240703T135648Z&X-Amz-Expires=300&X-Amz-Signature=0f731c70c66ce1b4a49d031ff5efccfe724a09e1412b9d78e2231a44a1a9f8ac&X-Amz-SignedHeaders=host&actor_id=5980033&key_id=0&repo_id=187995713&response-content-disposition=attachment%3B%20filename%3DSpec2-wip.pdf&response-content-type=application%2Foctet-stream

astares avatar Jul 03 '24 15:07 astares

image

image

astares avatar Jul 03 '24 15:07 astares

I see it now. My PDF reader does not search well. I will take a look. Thanks.

koendehondt avatar Jul 03 '24 15:07 koendehondt

Having a symbol "iconManager" represented with a break as "icon-Manager" is also not very fortunate

astares avatar Jul 03 '24 15:07 astares

The single reference to iconManager: has been replaced by iconProvider. See https://github.com/SquareBracketAssociates/BuildingApplicationWithSpec2/commit/ed91b898f442457183ff2c3c3c80564b800f62cf

Thanks again for the feedback.

koendehondt avatar Sep 03 '24 20:09 koendehondt