reactive-geocoder icon indicating copy to clipboard operation
reactive-geocoder copied to clipboard

- Updated and organized the imports;

Open tiarebalbi opened this issue 9 years ago • 4 comments

  • Refactored the methods in LocationService;
  • Updated Spring Boot version to 1.2.1.RELEASE;
  • Adjusted some config methods.

tiarebalbi avatar Feb 19 '15 12:02 tiarebalbi

Hey Tiarê, I was working in the same changes last night. I did a few different things that you did though

My locationEventStream method is as follow:

@Bean
    public Broadcaster<Location> locationEventStream(Environment env) {
        return Streams.broadcast(env.get());

    }

on findOne and update methods I used Environment.get() instead of Environment.cachedDispatcher()

and I also changed the ratpack version to 0.9.11

thiagogcm avatar Feb 20 '15 15:02 thiagogcm

@thiagogcm i agree with your observation, the only thing that i'll be checking is about the bean definition, as you can see by the picture bellow i don't have access to the method broadcast() on the class Streams.

i sent a parcial change with your comments.

screen

tiarebalbi avatar Feb 20 '15 16:02 tiarebalbi

I was checking here and the method broadcast() is not static. https://github.com/reactor/reactor/blob/master/reactor-core/src/main/java/reactor/rx/Stream.java#L306-L308

I'm not sure that this usage "Broadcaster.create()" is the better way to define this bean, i'm open for more opinion.

tiarebalbi avatar Feb 20 '15 17:02 tiarebalbi

That's weird.. I checked the API and it's static I'm working with M2 build since I couldn't find the RC1 API selection_006

thiagogcm avatar Feb 20 '15 22:02 thiagogcm