python-rtmidi icon indicating copy to clipboard operation
python-rtmidi copied to clipboard

Published 20 hours ago • verified publisher icon SpotlightKid

Build wheels using cibuildwheel

Open Czaki opened this issue 3 years ago • 6 comments

This PR adds building wheels using cibuildwheel which simplifies creating wheels and adds support for Linux wheels. It also changes macOS wheels from x86_64 to universal2 (to work on m1 machine).

I do not found an option to run tests on CI.

Here sample run https://github.com/Czaki/python-rtmidi/actions/runs/1253787788

Czaki avatar Sep 20 '21 14:09 Czaki

Many thanks for the PR. I'll be on holiday next week and hop to to find the time to have a look at it then. Thanks for your work and patience.

SpotlightKid avatar Sep 22 '21 16:09 SpotlightKid

@SpotlightKid Did you have a chance to look at this PR? It would be great to have a new set of wheels on PyPI as Python 3.10 has been released; also, I currently need to compile from source on Apple Silicon. Thanks a lot!

ntamas avatar Dec 03 '21 07:12 ntamas

@ntamas Not in detail yet, sorry. I'm away for the weekend, but I'll try to look at it next week. At first glance it looks good, though.

SpotlightKid avatar Dec 03 '21 12:12 SpotlightKid

Thanks! In the meanwhile I tried the PR In my own fork and it seems like it still works nicely and generates correct wheels for Win32, macOS and Linux; see here.

ntamas avatar Dec 06 '21 13:12 ntamas

Just updated to the last release of cibuildwheel. Disable musllinux wheels as it fails to detect pthread. I do not know if this check should be performed on musllinux (it may be built-in muslc).

https://github.com/Czaki/python-rtmidi/actions/runs/1545141326

Czaki avatar Dec 06 '21 15:12 Czaki

@SpotlightKid: can we proceed further with the integration of cibuildwheel? This would greatly simplify the installation process of many rtmidi dependant code bases.

Bubobubobubobubo avatar Sep 10 '22 09:09 Bubobubobubobubo

I'd love to see this in mainline - it fixes issues building for python 3.11

georgeharker avatar Feb 12 '23 23:02 georgeharker

Thanks for your contribution. It was probably used to create PR https://github.com/SpotlightKid/python-rtmidi/pull/119, superseding this one.

brunoenten avatar May 21 '23 07:05 brunoenten

As last time I check the #119 was failing so I kept it to make some wheel available for some folks.

If you need help with cibuildwheel feel free to ping

Czaki avatar May 21 '23 09:05 Czaki

True but it was superseded by https://github.com/SpotlightKid/python-rtmidi/pull/121 which fixed the cibuildwheel that remained. Both PR clearly used your work as a basis, so thanks for your contribution!

brunoenten avatar May 21 '23 11:05 brunoenten