spotifyd icon indicating copy to clipboard operation
spotifyd copied to clipboard

Initial volume wrong; rounding down

Open Icelk opened this issue 4 years ago • 6 comments

Description

When I set initial_volume in the config to 50, spotify_tui reports it as 49%. I have narrowed down this issue to being only initial_volume.

I know of a fix; just add one to the u16 after it's been mapped from 0-100 to 0x0000 to 0xFFFF. Should I open a PR?

To Reproduce

  1. Set initial_volume to a value.
  2. Enter a spotify client which can display volume in percent
  3. See how it's one less than expected.

Expected behavior

The volume should be what I set in the config.

Compilation flags

  • [x] dbus_mpris
  • [ ] dbus_keyring
  • [ ] alsa_backend
  • [ ] portaudio_backend
  • [x] pulseaudio_backend
  • [ ] rodio_backend

Versions (please complete the following information):

  • OS: Arch Linux
  • Spotifyd: bae6f1efcde4eaa3bbed2dec9ade5206139d6eb0
  • cargo: 1.47.0

Icelk avatar Apr 12 '21 07:04 Icelk

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 11 '21 07:07 stale[bot]

Still not resolved.

Icelk avatar Jul 11 '21 10:07 Icelk

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 09 '21 11:10 stale[bot]

Still not resolved.

Icelk avatar Oct 12 '21 07:10 Icelk

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 10 '22 11:01 stale[bot]

Still not resolved.

Icelk avatar Jan 12 '22 14:01 Icelk