spotifyd icon indicating copy to clipboard operation
spotifyd copied to clipboard

Fails to build with Rust > 1.79

Open 0323pin opened this issue 1 year ago • 2 comments

Please bump time to 0.3.36 or higher to fix build with Rust-1.80 and cut a new tag.

Else, building release fails with:

error[E0282]: type annotations needed for `Box<_>`
  --> /pbulk/work/audio/spotifyd/work/vendor/time-0.3.20/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
*** Error code 101

Thanks!

0323pin avatar Oct 17 '24 05:10 0323pin

I will try to get to it during the weekend, but if you need it right now, you should just be able to do cargo update.

eladyn avatar Oct 17 '24 17:10 eladyn

@eladyn Cheers, that would be appreciated.

if you need it right now, you should just be able to do cargo update

Yeah, I know that I could do that for personal use but, I'm asking this to fix the broken NetBSD package.

0323pin avatar Oct 17 '24 18:10 0323pin

This issue can likely be closed. I believe it was resolved in this PR: https://github.com/Spotifyd/spotifyd/pull/1297

davidgauch avatar Oct 29 '24 03:10 davidgauch

True, closing now. Thanks.

0323pin avatar Oct 29 '24 04:10 0323pin