sweat-token icon indicating copy to clipboard operation
sweat-token copied to clipboard

feat: App Dashboard Facelift

Open sam-potter opened this issue 2 years ago • 11 comments

#149

sam-potter avatar Oct 13 '22 04:10 sam-potter

Deploy Preview for sporosdaoapp-dev ready!

Name Link
Latest commit fece58ee35d05bbebf5688ce2f493976ee86d152
Latest deploy log https://app.netlify.com/sites/sporosdaoapp-dev/deploys/63478e044b4001000883c33d
Deploy Preview https://deploy-preview-163--sporosdaoapp-dev.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 13 '22 04:10 netlify[bot]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Oct 13 '22 04:10 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

sam-potter avatar Oct 13 '22 04:10 sam-potter

Based on https://www.figma.com/file/HjgPX0qjMYgvDjeliS4EwD/Sporos-DAO-App?node-id=552%3A84193

I've temporarily implemented @heroicons for their icons, lmk what the correct plan for icons is.

What's the plan for mobile? Is the dashboard going to support a mobile view?

I've added tailwindcss. I think using it should be permanent. Given that the DS is based off of Tailwind UI components, it basically means many of the components are already roughly built for us (will need minor tweaks) and we only need to piece them together.

sam-potter avatar Oct 13 '22 04:10 sam-potter

image

sam-potter avatar Oct 13 '22 04:10 sam-potter

@sam-potter - the only thing here is that the MUI theme has been styled to work with with the design system. if we move to tailwind, most of that work would need to be redone.

brightiron avatar Oct 13 '22 19:10 brightiron

see: https://github.com/SporosDAO/sweat-token/pull/162

brightiron avatar Oct 13 '22 19:10 brightiron

@brightiron - what was the reason for choosing MUI? What parts of the DS have been implemented already?

sam-potter avatar Oct 13 '22 20:10 sam-potter

@brightiron - what was the reason for choosing MUI? What parts of the DS have been implemented already?

thats more of a question for @ivelin . they were already using it when i started helping with theming. and the request came through to create a mui theme on top of the design system.

brightiron avatar Oct 13 '22 20:10 brightiron

@brightiron - what was the reason for choosing MUI? What parts of the DS have been implemented already?

thats more of a question for @ivelin . they were already using it when i started helping with theming. and the request came through to create a mui theme on top of the design system.

Hi folks. Sorry for the delay. I was submersed in devcon activities this week. Great time in Bogota.

The choice of MUI was due to:

  • very limited coding capacity
  • Goal to launch a reasonable functional app ASAP
  • MUI’s reputation for a well polished system with reasonable defaults that end users are familiar with across a wide range of devices , modalities and modes.
  • I was aware MUI is not the most friendly system for custom design but I did not want to risk delaying initial release too much. Something functional that just works today is a lot better than something super cool that either half works today or works fine sometime next year.

Happy to discuss switching to a different system after our MMP which is targeted for end of October.

Hope that helps explain the rationale.

ivelin avatar Oct 16 '22 00:10 ivelin

@ivelin good to hear you enjoyed devcon. Heard great things about it from everyone.

Your rationale for choosing MUI is perfectly understandable.

In terms of this PR, I'll revert the tailwindcss implementation. I'll pause working further until implementation of the DS into MUI from @brightiron is further along.

sam-potter avatar Oct 17 '22 21:10 sam-potter