gumtree-spoon-ast-diff icon indicating copy to clipboard operation
gumtree-spoon-ast-diff copied to clipboard

Changes on Signature of inner class

Open martinezmatias opened this issue 4 years ago • 0 comments

If we update the constructor call of a inner class, e.g: (from case examples/t_225073)

- new Lock.With(directory.makeLock("commit.lock")) {..
+ new Lock.With(directory.makeLock("commit.lock"), COMMIT_LOCK_TIMEOUT) { ...

when the diff produces two changes (all ops): update new class and insert literal., and one root op (the update). I would say that the update of new class is redundant, but if we keep only the insert (by changing the label of the new class to print the name rather than the signature) we lose some information about the context of the change.

This issue was found when creating the fix for https://github.com/SpoonLabs/gumtree-spoon-ast-diff/issues/147 created by @algomaster99

martinezmatias avatar Mar 09 '21 20:03 martinezmatias