nbt icon indicating copy to clipboard operation
nbt copied to clipboard

LITTLE_ENDIAN Floats and Doubles are read as BIG_ENDIAN

Open xcube16 opened this issue 5 years ago • 0 comments

https://github.com/flow/nbt/blob/7a1b6d986e6fbd01862356d47827b8b357349a22/src/main/java/com/flowpowered/nbt/stream/EndianSwitchableInputStream.java#L100-L122

As you can see, readInt() and readLong() take care of the endian ness, but readFloat() and readDouble() also try to take care of flipping the bytes around! This causes LITTLE_ENDIAN Floats and Doubles to be read as BIG_ENDIAN.

    public float readFloat() throws IOException {
        return Float.intBitsToFloat(readInt());
    }

    public double readDouble() throws IOException {
        return Double.longBitsToDouble(readLong());
    }

That should fix it.

~~If someone could sneak that into there next PR that would be nice! ;)~~ Fixed in PR #16

xcube16 avatar Feb 15 '19 01:02 xcube16