nethers from biomes o plenty cannot be created or warped to after updating from 3902 to 3903 (and later, up to recent 4010)

[bhi-elliot]

I am currently running

• SpongeForge version: 1.12.2-2838-7.1.7-RC3902
• Forge version: 1.12.2 14.23.5.2838 universal
• Java version: 1.8.0_221-b11
• Operating System: Windows 10

Sponge plugins:

GriefPrevention 4.3.0.692 KaroglanSignEditor 3.4.1 LuckPerms Sponge 4.4.29 Nucleus 1.14.0 S7.1 project core 7.2.0 0.3.0 project inventories 7.2.0 0.12.2 project portals 7.2.0 0.15.2 project worlds 7.2.0 0.13.1 TimeWarp 2.3 r7.0.0 worldedit sponge 7.1.0–6.1.10 SNAPSHOT

Mods:

Aroma1997Core 1.12.2 2.0.0.2 b165 AromaBackup 1.12.2 3.0.0.0 b129 BetterFps 1.4.8 BiblioCraft 2.4.5 Biomes O’ Plenty 7.0.1.2441 BuildCraft 7.99.24.2 CodeChickenLib 3.2.3.357 foamfix 0.10.5 Forestry 5.8.2.394 IndustrialCraft 2 2.8.187 ex112 ironchest 7.0.59.842 JEI 4.15.0.289 NotEnoughItems 2.4.3.245

Issue Description

Bit of a weird one here. But what I was doing was creating Biomes o Plenty nether worlds using Project Worlds (and Project Core). Here is the command I would give:

/world create NetherWorldName -dimension biomesoplenty:nether -generator biomesoplenty:b_i_o_m_e_s_o_p -difficulty minecraft:easy -gameMode survival -seed beans --usesMapFeatures --commandsAllowed

In SpongeForge 3902, this would produce a world that worked. When I do that with 3903 or later (tried each one up to 3913), and I teleport to that world, it is a strange mix of the overworld and the nether. This is also the case if players use a nether portal to get there.

For admin to port there I was using the command /world tp NetherWorldName from Project Worlds

Let me know if there is other info you would like. Hope this helps! Thank you!

[gabizou]

Good reproduction, likely to do with our changes made to increase mod compatibility of world generators. Specifically the issue may lie in the changes here: https://github.com/SpongePowered/SpongeForge/commit/fbe7f760f54bc1e71f807e756b722a4f31bb1c60

[bhi-elliot]

update: Just tried updating server to recommended build 1.12.2-2838-7.1.9

Issue persists. Players using nether portals to warp to their respective world's nether get warped strangely and they are unable to move. Where they go looks like a mix of the overworld and the nether. For example, on my server there are mutliple worlds, each with their own nether. The nethers with Biomes O Plenty cannot be warped to via portals or commands as of 1.12.2-2838-7.1.9.

I had to revert to 1.12.2-2838-7.1.7-RC3902

I believe it is not just world gen, but maybe something to do with custom nethers?

Thank you for considering.

[bhi-elliot]

update: Just tried updating server to 1.12.2-2838-7.2.1-RC4010

Forge: 1.12.2-14.23.5.2847 BoP: 1.12.2-7.0.1.2444

Issue persists. Even trying to teleport into a nether world that is made from Biomes O Plenty causes the strangeness. Portals definitely don't work properly into nethers with BoP biomes and OPs cannot teleport to those words.