SpongeAPI icon indicating copy to clipboard operation
SpongeAPI copied to clipboard

Published 20 hours ago • verified publisher icon SpongePowered

Add WallConnectionState

Open Lignium opened this issue 2 years ago • 2 comments

SpongeAPI | Sponge

Lignium avatar Jul 29 '22 01:07 Lignium

I did add those in API9 as Properties:

https://github.com/SpongePowered/SpongeAPI/blob/api-9/src/main/java/org/spongepowered/api/data/type/WallType.java https://github.com/SpongePowered/SpongeAPI/blob/api-9/src/main/java/org/spongepowered/api/state/EnumStateProperties.java#L99

Faithcaio avatar Aug 06 '22 22:08 Faithcaio

@Faithcaio I find the name WallType extremely unfortunate in this case. This is not about the wall as such, but about its connection, and there are 4 such connections. And of course, such an implementation is not complete. It does not allow the use of BlockState#mergeWith() and is also inconsistent with the generic Keys#CONNECTED_DIRECTIONS.

Lignium avatar Aug 07 '22 00:08 Lignium

Thanks for your contribution! This is being addressed in api-10 with a more generic approach.

Superseded by https://github.com/SpongePowered/SpongeAPI/pull/2440

ImMorpheus avatar Jan 21 '23 21:01 ImMorpheus