Sponge icon indicating copy to clipboard operation
Sponge copied to clipboard

Suspected Mixin Incompatibility with Vault Hunters Mod

Open jakematt123 opened this issue 3 years ago • 3 comments

Affected Product(s)

SpongeForge

Version

1.16.5-36.2.5-8.1.0-RC1164

Operating System

Linux (Unknown Distro)

Java Version

Java 8

Plugins/Mods

Mods:
Vault Hunters Modpack (VERSION 1.13.3) (https://vault-hunters.fandom.com/wiki/Mods)

Plugins: None

Describe the bug

Startup crash when using SpongeForge for the first time. The crash is at the bottom of the paste provided. It seems to be an issue with Sponge and The_Vault mod.

Link to logs

https://pastebin.com/u1fbr3TB

jakematt123 avatar Jul 26 '22 23:07 jakematt123

It seems this is still breaking Sponge's mixins using recent versions of the modpack (Vault Hunters 1.13.8, containing Vault mod version 1.8.3p1.13.8L) and SpongeForge RC1182. Here's the problematic mod: https://www.curseforge.com/minecraft/mc-mods/vault-hunters-official-mod

Inscrutable avatar Sep 26 '22 01:09 Inscrutable

Is this needs to be fixed by vault developers or is there anything sponge can do in this case. Just came across this issue.

dvtkrlbs avatar Oct 08 '22 18:10 dvtkrlbs

This is the conflict:

@Redirect conflict. Skipping 
assets/the_vault/the_vault.mixins.json:MixinServerPlayerEntity->
   @Redirect::yes(Lnet/minecraft/world/GameRules;Lnet/minecraft/world/GameRules$RuleKey;)Z with priority 1000, 
already redirected by 
mixins.sponge.core.json:server.level.ServerPlayerMixin->
   @Redirect::tracker$useKeepFromBridge(Lnet/minecraft/world/GameRules;Lnet/minecraft/world/GameRules$RuleKey;Lnet/minecraft/entity/player/ServerPlayerEntity;Z)Z with priority 1101

Sponge redirects the GameRules.RULE_KEEPINVENTORY evaluation to enable overriding the rule on players individually. https://github.com/SpongePowered/Sponge/blob/ae86a5c88c543c1ddbe6f26c7665499148e3ebc2/src/mixins/java/org/spongepowered/common/mixin/core/server/level/ServerPlayerMixin.java#L700

Faithcaio avatar Oct 31 '22 14:10 Faithcaio