Ore icon indicating copy to clipboard operation
Ore copied to clipboard

Project level warnings/messages

Open Katrix opened this issue 5 years ago • 4 comments

As discussed on SPORE, it should be possible to define a warnings/message that's shown for project level. Needs the message table described in #707

Katrix avatar Nov 17 '18 22:11 Katrix

I don't fully understand this. What's the intention of these warnings?

felixoi avatar Nov 18 '18 07:11 felixoi

For example, if a plugin is sending users offsite, we want to warn about that. Think the new plugin info at the top, but generalized for any warning.

Katrix avatar Nov 18 '18 10:11 Katrix

Theoretically we have an offsite filter here https://github.com/SpongePowered/Ore/blob/8aec09e2e6f5e1d099a929d30601f1f3737290b3/app/models/project/Page.scala#L210 but it seems to be broken. If we fix this I don't see any usecase for this but I'm open for a discussion. All projects the user really needs to be warned about should be hidden IMO.

felixoi avatar Nov 18 '18 14:11 felixoi

That was just one example. The point was that the reviewers wanted a system where they could apply project level info that they don't know the specifics of in advance. Also, the link out warning doesn't tell you why you're leaving the site, just that you are. It also doesn't warn you before you actually click on a link.

One specific case that was brought up was a plugin linking to a dependency not on Ore. The reviewers wanted a loud and clear warning for this for example.

Katrix avatar Nov 18 '18 16:11 Katrix