Mixin icon indicating copy to clipboard operation
Mixin copied to clipboard
verified publisher icon SpongePowered

Preserve method static access for static Invokers

Open CertainLach opened this issue 5 years ago • 1 comments

Before this commit, static modifier was dropped from generated method, resulting in wrong method being generated (no static modifier). However, bytecode was already fine, there is no aload_0, and variable offsets is ok.

image

TODO

Validate that targetMethod.access & ACC_STATIC == accessorMethod.access & ACC_STATIC (Can't find where in codebase i should add this check)

CertainLach avatar Jun 18 '20 11:06 CertainLach

How did you manage to create 3 commits for such a simple change?

Mumfrey avatar Jun 18 '20 12:06 Mumfrey