Hans Lemuet
Hans Lemuet
Just fixed conflicts, if you want to review again @joshbuker
@willnet sorry I won't have time to dedicate to this in the coming weeks
Great! Can you please add a changelog entry? Also, can we add a test that uses this new behavior?
@woller can you rebase? We fixed CI in `main`.
This is fixed since #108 has been merged.
Hi @joshbuker, I'd be happy to help review and merge a few PRs!
@jonmchan it's a separate repo: https://github.com/Sorcery/sorcery-rework
Hi @joelzwarrington, no particular reason if I remember correctly. I think we can totally move the files to `lib`. Would that imply that when we want to override a ViewComponent::Form...
FYI `OpenStruct` is only used [in spec files](https://github.com/search?q=repo%3Arswag%2Frswag%20openstruct&type=code) currently, so I think it will be pretty straightforward to change to `Struct`. I acknowledge it can be done separately, though.
I think I encountered a very similar issue that I documented in this repo: https://github.com/Spone/phlex_lookbook_safe_buffer/blob/main/test/components/previews/broken_button_preview.rb You can see the issue locally at http://localhost:3000/lookbook/inspect/broken_button/broken_buttons > This component renders correctly in views....