Florent Morselli
Florent Morselli
> there are numeric identifiers with leading 0 such as 020 for Andorra OK I was not aware of that. Makes sense to let it as a string. Thanks for...
> So now this provides a JWT-based handler in addition to the user-info one. Huge work! I was quite busy lately and hadn't paid attention to this PR. I must...
Hi @vincentchalamon and al, I took time to review this PR and to be honest I do not have any questions or remarks. It looks good to me so far....
Hi, This seems legit to me, especially when the GDPR requires personal data to be protected. See #51434.
Many thanks for your comments. Indeed there is something wrong with some cases [such as this one](https://github.com/symfony/symfony/blob/48c8c981851580b877c3b82c7980fc55350a886d/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php#L1529) where `en` is selected when `en-us` is preferred just because of the order...
Hi, I updated the PR and changed the comparison logic: * If an exact match exists, it is returned * Else if a similar locale exists, the corresponding language is...
> In your exemple, what would happen if the default locale were defined as « fr, en » ? You mean if the supported locales are `['fr', 'en']` instead of...
Many thanks for the last suggestions. The PR is now rebased, squashed and ready for other reviewers comments
This looks good to me. The `@final` is used to avoid incompatibilities with old PHP versions. But at a time, it will become a `final` statement. You should not extend...
Hi 👋🏼, There is no configuration option to disable the data collector. I think this is a nice addition. Would you mind to create a PR for that? Regards.