refreshVersions icon indicating copy to clipboard operation
refreshVersions copied to clipboard

Review bundled dependencies from #559

Open jmfayard opened this issue 3 years ago • 1 comments

We want to do small and fast PR but that was not the case of #559 who grew to be too big and stale. So I merged it and created this issue so that @LouisCAD can check a posteriori whether the following dependencies are OK

  • Jetbrains.exposed.*
  • Ktor2.*
  • KotlinX.lincheck.*
  • KotlinX.multik.*
  • KotlinX.dataframe.*
  • KotlinX.deeplearning.*
  • Koin.navigation
  • Kotlinx.dataframe
  • Testing.cucumber
  • Testing.assertj
  • Testing.jsonAssert
  • Testing.powermock
  • Testing.restAssured

jmfayard avatar Aug 02 '22 07:08 jmfayard

  • [ ] Arrow: review if missing dependencies https://search.maven.org/search?q=a:arrow-stack
  • [x] KotlinX: remove dataframe.gradlePlugin
  • [x] KotlinX: remove import
  • [x] Spring: remove boms.springclmoud
  • [x] Square.okhttp3: move comments to Kdoc
  • [x] Ktor: remove Ktor1 vs Ktor2, use built-in mechanism, add this comment // TODO: Migrate to ktor2. See https://ktor.io/docs/migrating-2.html
  • [x] ~Testing.kotest.kotestExtensions => move to kotestProperty and check if version is the same for both dependencies. I think it's not~ Wasn't exactly that, but should be handled now.
  • [x] Remove val jsonAssert = DependencyNotation("org.skyscreamer", "jsonassert")
  • [x] Remove Testing.cucumber because too many dependencies/versions available at https://search.maven.org/search?q=g:io.cucumber
  • [x] Remove Testing.powermock

Not for now

  • [ ] How to handle third party DN like for Ktor2 plugins?

jmfayard avatar Aug 11 '22 10:08 jmfayard

I think Ktor2 version key rules were also forgotten. I'm adding them back.

LouisCAD avatar Aug 17 '22 15:08 LouisCAD