refreshVersions icon indicating copy to clipboard operation
refreshVersions copied to clipboard

Incomplete implementation of using the versions.properties from

Open trevormerritt opened this issue 4 years ago • 1 comments

🐛 Describe the bug

When attempting to use the Jetpack Compose plugin, RefreshVersions doesn't use the configuration value from settings.gradle.kts causing the RefreshVersions plugin to not use the specified file and fail.

⚠️ Current behavior

When attempting to build a project with Jetpack Compose and RefreshVersions and a preferences file specified in the settings.gradle.kts file, the project fails as RefreshVersions does not use the value from the settings file.

✅ Expected behavior

I expect the RefreshVersions plugin to use the configuration file I specified.

💣 Steps to reproduce

Create project with gradle and have multiple included builds. Each line below signifies a project and its relative location to the root project, with the exception of the versions.properties file

/config/refreshVersions/versions.properties /server /util/common /util/commonui /util/buildupdaters /client/godmode /client/headless /client/usermode

In the root settings.gradle.kts I've included the versionsPropertiesFile to specify a common file to set versions for all included builds. I've also added jetpack compose, builds 0.5.0 through current and had the same results.
In each project's settings.gradle.kts, I've included the versionsPropertiesFile value to point to the same settings.gradle.kts. When attempting to build, sometimes it doesn't.

I will be submitting a PR to address this in the next few hours.

📱 Tech info

trevormerritt avatar Sep 13 '21 12:09 trevormerritt

Hello, can you please provide the build.gradle.kts and settings.gradle.kts involved files, or a minimal reproducing project?

LouisCAD avatar Jan 24 '22 00:01 LouisCAD