Matheus Gabriel Werny
Matheus Gabriel Werny
Thank you for the review. I am glad that this feature is well perceived. Regarding your first recommendation, do you suggest a switch (member variable on class `Server`) which serves...
Done. Please review. All tests pass either with or without macro `CPPHTTPLIB_OPENSSL_SUPPORT`. While the implementation is fine, please take a look at minor things I just assumed and guessed. -...
The result from Claude is good. Please adjust for consistency. I had to make `st_` and `ret_` from `httplib::detail::FileStat` public. ### Discovered Issues: issue 1 Proper issue. Fixed it. ###...
In summary, take a special look at the following and adjust for consistency. - name and location of member variable `is_etag_enabled` - name and location of member function (declaration and...
See https://github.com/yhirose/cpp-httplib/pull/2243/commits/60d2a37921ecc5161badb4d1ab8267b9732f9696. ### Issue 1 Not needed, https://stackoverflow.com/questions/18850752/must-i-call-atomic-load-store-explicitly. Personally, I prefer not to call `load()` or `store()`. ### Issue 2 Fixed. Relict from old ETag generation. ### Issue 3 Fixed....
**With update** In summary, take a special look at the following and adjust for consistency. - name and location of member variable is_etag_enabled - name and location of member function...
What about the current state of approval for this?
### Critical issues #### Recommendation 1 Personally, I disagree with the suggestion. I like exceptions. #### Recommendation 2 This recommendation conflicts with a prior recommendation. First, I had a hash...
I already did the setup with GlobalRegistrator.
The test I provided is not run in a browser. It is a test that is run with a test runner which is not inside a browser as usual. That...