Expenso icon indicating copy to clipboard operation
Expenso copied to clipboard

Published 20 hours ago • verified publisher icon Spikeysanju

implementing bio-metric pull

Open maifeeulasad opened this issue 3 years ago • 4 comments

Issue : https://github.com/Spikeysanju/Expenso/issues/52 Discussion : https://github.com/Spikeysanju/Expenso/discussions/58

maifeeulasad avatar Mar 19 '21 08:03 maifeeulasad

Screenshot_2021-03-27-14-06-50-113_dev.spikeysanju.expensetracker.jpg

Hey @maifeeulasad I have reviewed your PR it looks good. But the main purpose of this Bio-Metric authentication is to provide privacy.

But in above picture we clearly see able to see the dashboard values.

Also I noticed application crashes whenever I tap apart from the the authenticate area.

Can you please fix above two issues if possible. Once it's done I will be happy to merge your PR.

Thanks for your PR. Have a great day buddy!

Spikeysanju avatar Mar 27 '21 08:03 Spikeysanju

@Spikeysanju can you check out once more, I've update the PR. currently it starts in a different fragment, an authentication fragment. then if it is properly authenticated, it goes to doing whatever it was doing previously. You can check directly here : https://github.com/Spikeysanju/Expenso/pull/59/commits/ca9ad274df024e7e6d83a742d501888005c109b3

And let me know if it needs something more.

maifeeulasad avatar Mar 28 '21 10:03 maifeeulasad

@maifeeulasad Buddy thanks for the new PR. I will review this PR by EOD. Have a great day 🙌

Spikeysanju avatar Apr 10 '21 03:04 Spikeysanju

Hello, @Spikeysanju hope you are doing well. Have you checked out this PR. Can I get any update on this? If this PR lacks anything, please let me know.

maifeeulasad avatar May 30 '21 18:05 maifeeulasad