spikeinterface First draft to go to pyproject.toml

First draft to go to pyproject.toml

Open samuelgarcia opened this issue 3 years ago • 3 comments

Oct 04 '22 15:10 samuelgarcia

Hi @caniko. Here a first draft for pyproject.toml. It is not poetry based (sorry) we stick with setuptools for now. Any feeedback welcome.

Do you know a way to also include other files (matlab source) to be able to remove the old MANIFEST.in ?

Oct 05 '22 07:10 samuelgarcia

Great! I'll take a look later today.

Regarding MANIFEST.in, with poetry; setuptools has no support for this currently.

Oct 05 '22 13:10 caniko

Hope the feedback is constructive, @samuelgarcia! Otherwise, LGTM :100:

Oct 06 '22 10:10 caniko

You didn't see this earlier? @alejoe91 @samuelgarcia

I think I forgot to submit, I had made these comments along with my first comment 14 days ago.

Hope the feedback is constructive, @samuelgarcia! Otherwise, LGTM 100

So this must've made little sense considering that there was no feedback :laughing:

Oct 20 '22 09:10 caniko

@caniko nope! Thanks for the constructive feedback! We'll make a separate PR!

Oct 20 '22 09:10 alejoe91